Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3464)

Unified Diff: chrome/browser/ui/fullscreen_controller.cc

Issue 10173030: User Gesture plumbed from Renderer to Browser's FullscreenController::RequestToLockMouse. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/fullscreen_controller.cc
diff --git a/chrome/browser/ui/fullscreen_controller.cc b/chrome/browser/ui/fullscreen_controller.cc
index f0e3514b5fca94014353dde3307c42de4d0925e6..cc206459167615fc957dabbf8230d5ee21c52737 100644
--- a/chrome/browser/ui/fullscreen_controller.cc
+++ b/chrome/browser/ui/fullscreen_controller.cc
@@ -59,7 +59,11 @@ bool FullscreenController::IsMouseLockedOrPending() const {
return mouse_lock_state_ != MOUSELOCK_NOT_REQUESTED;
}
-void FullscreenController::RequestToLockMouse(WebContents* tab) {
+void FullscreenController::RequestToLockMouse(WebContents* tab,
+ bool /* user_gesture */) {
yzshen1 2012/04/25 23:24:36 One space after bool, please.
+ // TODO(scheib) user_gesture required for Mouse Lock in Windowed Mode.
+ // See http://crbug.com/107013, which will land in multiple patches.
+
// Mouse Lock is only permitted when browser is in tab fullscreen.
if (!IsFullscreenForTabOrPending(tab)) {
tab->GotResponseToLockMouseRequest(false);

Powered by Google App Engine
This is Rietveld 408576698