Issue 10173029: Add a PPB_Flash_Print interface and implement in Chrome.

Issue 10173029: Add a PPB_Flash_Print interface and implement in Chrome. (Closed)

Created:
8 years, 8 months ago by brettw

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, piman+watch_chromium.org, ihf+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a PPB_Flash_Print interface and implement in Chrome. This shares the implementation with the PDF interface. I put the implementation in the Flash file since that file was already so much smaller, and this one function didn't seem worth creating a new shared file for. This also does some cleanup of the Chrome PPB interfaces. I separated out the implementation of the NaCl interface into its own file, and moved everything into a new renderer/pepper subdirectory. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134285

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+232 lines, -628 lines)			Patch
M	chrome/chrome_renderer.gypi	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/renderer/chrome_ppapi_interfaces.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/renderer/chrome_ppapi_interfaces.cc	View		1 chunk	+0 lines, -126 lines	0 comments	Download
D	chrome/renderer/chrome_ppb_pdf_impl.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	chrome/renderer/chrome_ppb_pdf_impl.cc	View		1 chunk	+0 lines, -386 lines	0 comments	Download
A +	chrome/renderer/pepper/chrome_ppapi_interfaces.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A	chrome/renderer/pepper/chrome_ppapi_interfaces.cc	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	chrome/renderer/pepper/ppb_flash_print_impl.h	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	chrome/renderer/pepper/ppb_flash_print_impl.cc	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/renderer/pepper/ppb_nacl_private_impl.h	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A +	chrome/renderer/pepper/ppb_nacl_private_impl.cc	View	1 2	4 chunks	+17 lines, -42 lines	0 comments	Download
A	chrome/renderer/pepper/ppb_pdf_impl.h	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
A +	chrome/renderer/pepper/ppb_pdf_impl.cc	View	1	6 chunks	+22 lines, -23 lines	0 comments	Download
M	ppapi/api/private/ppb_flash.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
A	ppapi/api/private/ppb_flash_print.idl	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	ppapi/c/private/ppb_flash.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	ppapi/c/private/ppb_flash_print.h	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/10173029/diff/1/chrome/renderer/pepper/chrome_ppapi_interfaces.h File chrome/renderer/pepper/chrome_ppapi_interfaces.h (right): http://codereview.chromium.org/10173029/diff/1/chrome/renderer/pepper/chrome_ppapi_interfaces.h#newcode5 chrome/renderer/pepper/chrome_ppapi_interfaces.h:5: #ifndef CHROME_RENDERER_CHROME_PPAPI_INTERFACES_H_ nit: guards http://codereview.chromium.org/10173029/diff/1/chrome/renderer/pepper/ppb_pdf_impl.cc File chrome/renderer/pepper/ppb_pdf_impl.cc (right): http://codereview.chromium.org/10173029/diff/1/chrome/renderer/pepper/ppb_pdf_impl.cc#newcode362 ...

8 years, 8 months ago (2012-04-25 21:31:34 UTC) #2

lgtm

Expand Messages | Collapse Messages