Issue 10173023: Use safe string utilities to fix Windows build error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10173023: Use safe string utilities to fix Windows build error. (Closed)

Created:
8 years, 8 months ago by danno

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use safe string utilities to fix Windows build error. R=mstarzinger@chromium.org TEST=waterfall goes green Committed: https://code.google.com/p/v8/source/detail?r=11434

Patch Set 2 : review feedback #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -22 lines)			Patch
	M	src/hydrogen.cc	View	1	4 chunks	+25 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one comment). https://chromiumcodereview.appspot.com/10173023/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/10173023/diff/1/src/hydrogen.cc#newcode1634 src/hydrogen.cc:1634: if (string_len > sizeof(underlying_buffer)) { ...

8 years, 8 months ago (2012-04-25 13:09:53 UTC) #1

danno

8 years, 8 months ago (2012-04-25 15:40:34 UTC) #2

landed

http://codereview.chromium.org/10173023/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/10173023/diff/1/src/hydrogen.cc#newcode1634
src/hydrogen.cc:1634: if (string_len > sizeof(underlying_buffer)) {
On 2012/04/25 13:09:53, Michael Starzinger wrote:
> I think this condition can never be true. Can we drop this block (or at least
> make it an assertion)?

Done.

Expand Messages | Collapse Messages

Issue 10173023: Use safe string utilities to fix Windows build error. (Closed)

Description

Patch Set 1 #

Patch Set 2 : review feedback #

Messages