Issue 10173013: Increase chromium.app size expectations after clang roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10173013: Increase chromium.app size expectations after clang roll. (Closed)

Created:
8 years, 8 months ago by Nico

Modified:
8 years, 8 months ago

Reviewers:
cmp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/tools/perf_expectations/

Visibility:
Public.

More Reviews

Description

Increase chromium.app size expectations after clang roll. See http://llvm.org/pr12645 for investigation / discussion. TBR=cmp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133783

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	perf_expectations.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cmp

8 years, 8 months ago (2012-04-25 00:08:13 UTC) #2

lgtm

I would have used 133696:133792 since the range before 133696 is so low and is
no longer relevant.

The upstream bug points to ChromiumFramework and this change doesn't adjust
ChromiumFramework.  Should we set the tolerance for these to be closer to 0
(maybe 5% is too high)?

Expand Messages | Collapse Messages