Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: vm/stack_frame_ia32.cc

Issue 10173008: Simplify representation of stack frames. Remove the special types DartFrame/StubFrame and instead u… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/stack_frame.cc ('k') | vm/stack_frame_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/stack_frame_ia32.cc
===================================================================
--- vm/stack_frame_ia32.cc (revision 6919)
+++ vm/stack_frame_ia32.cc (working copy)
@@ -18,17 +18,6 @@
static const int kSpOffsetFromPreviousFp = 2 * kWordSize;
-static bool ExitedFromStub(uword exit_marker) {
- if (exit_marker != 0) {
- uword caller_pc = *reinterpret_cast<uword*>(exit_marker + kWordSize);
- uword call_instr_pc = caller_pc - CallPattern::InstructionLength();
- uword call_target = CallPattern(call_instr_pc).TargetAddress();
- return StubCode::InStubCallToRuntimeStubCode(call_target);
- }
- return false;
-}
-
-
intptr_t StackFrame::PcAddressOffsetFromSp() {
return kPcAddressOffsetFromSp;
}
@@ -53,7 +42,6 @@
Isolate* current = Isolate::Current();
uword exit_marker = current->top_exit_frame_info();
frames_.fp_ = exit_marker;
- frames_.from_stub_exitframe_ = ExitedFromStub(exit_marker);
}
@@ -61,7 +49,6 @@
uword exit_address = entry_.fp() + kExitLinkOffsetInEntryFrame;
uword exit_marker = *reinterpret_cast<uword*>(exit_address);
frames_.fp_ = exit_marker;
- frames_.from_stub_exitframe_ = ExitedFromStub(exit_marker);
frames_.sp_ = 0;
}
« no previous file with comments | « vm/stack_frame.cc ('k') | vm/stack_frame_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698