Simplify representation of stack frames. Remove the special types DartFrame/StubFrame and instead u…

vm/code_generator.cc

Index: vm/code_generator.cc
===================================================================
--- vm/code_generator.cc	(revision 6912)
+++ vm/code_generator.cc	(working copy)
@@ -344,7 +344,7 @@
                 String::Handle(type.Name()).ToCString());
     }
     DartFrameIterator iterator;
-    DartFrame* caller_frame = iterator.NextFrame();
+    StackFrame* caller_frame = iterator.NextFrame();
     ASSERT(caller_frame != NULL);

[srdjan, 2012/04/24 23:19:41]

Should we add here and elsewhere an assert that caller_frame IsDartFrame?

[siva, 2012/04/25 01:14:20]

Done.

     const Function& function = Function::Handle(
         caller_frame->LookupDartFunction());
@@ -363,7 +363,7 @@
   if (type.IsInstantiated() &&
       !Class::Handle(type.type_class()).HasTypeArguments()) {
     DartFrameIterator iterator;
-    DartFrame* caller_frame = iterator.NextFrame();
+    StackFrame* caller_frame = iterator.NextFrame();
     ASSERT(caller_frame != NULL);
     const Code& code = Code::Handle(caller_frame->LookupDartCode());
     ASSERT(!code.IsNull());
@@ -457,7 +457,7 @@
                 String::Handle(dst_type.Name()).ToCString());
     }
     DartFrameIterator iterator;
-    DartFrame* caller_frame = iterator.NextFrame();
+    StackFrame* caller_frame = iterator.NextFrame();
     ASSERT(caller_frame != NULL);
     const Function& function = Function::Handle(
         caller_frame->LookupDartFunction());
@@ -487,7 +487,7 @@
   if (dst_type.IsInstantiated() &&
       !Class::Handle(dst_type.type_class()).HasTypeArguments()) {
     DartFrameIterator iterator;
-    DartFrame* caller_frame = iterator.NextFrame();
+    StackFrame* caller_frame = iterator.NextFrame();
     ASSERT(caller_frame != NULL);
     const Code& code = Code::Handle(caller_frame->LookupDartCode());
     ASSERT(!code.IsNull());
@@ -648,7 +648,7 @@
   // the target method.
   ASSERT(arguments.Count() == kPatchStaticCallRuntimeEntry.argument_count());
   DartFrameIterator iterator;
-  DartFrame* caller_frame = iterator.NextFrame();
+  StackFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
   uword target = 0;
   Function& target_function = Function::Handle();
@@ -673,7 +673,7 @@
 RawCode* ResolveCompileInstanceCallTarget(Isolate* isolate,
                                           const Instance& receiver) {
   DartFrameIterator iterator;
-  DartFrame* caller_frame = iterator.NextFrame();
+  StackFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
   int num_arguments = -1;
   int num_named_arguments = -1;
@@ -817,7 +817,7 @@
     return target_function.raw();
   }
   DartFrameIterator iterator;
-  DartFrame* caller_frame = iterator.NextFrame();
+  StackFrame* caller_frame = iterator.NextFrame();
   ICData& ic_data = ICData::Handle(
       CodePatcher::GetInstanceCallIcDataAt(caller_frame->pc()));
 #if defined(DEBUG)
@@ -1284,7 +1284,7 @@
   ASSERT(arguments.Count() == kDeoptimizeRuntimeEntry.argument_count());
   const Smi& deoptimization_reason_id = Smi::CheckedHandle(arguments.At(0));
   DartFrameIterator iterator;
-  DartFrame* caller_frame = iterator.NextFrame();
+  StackFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
   const Code& optimized_code = Code::Handle(caller_frame->LookupDartCode());
   const Function& function = Function::Handle(optimized_code.function());