Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Side by Side Diff: vm/debugger.cc

Issue 10173008: Simplify representation of stack frames. Remove the special types DartFrame/StubFrame and instead u… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « vm/code_generator_x64.cc ('k') | vm/exceptions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 6
7 #include "vm/code_generator.h" 7 #include "vm/code_generator.h"
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 849 matching lines...) Expand 10 before | Expand all | Expand 10 after
860 } 860 }
861 861
862 862
863 void Debugger::BreakpointCallback() { 863 void Debugger::BreakpointCallback() {
864 ASSERT(initialized_); 864 ASSERT(initialized_);
865 865
866 if (ignore_breakpoints_) { 866 if (ignore_breakpoints_) {
867 return; 867 return;
868 } 868 }
869 DartFrameIterator iterator; 869 DartFrameIterator iterator;
870 DartFrame* frame = iterator.NextFrame(); 870 StackFrame* frame = iterator.NextFrame();
871 ASSERT(frame != NULL); 871 ASSERT(frame != NULL && frame->IsDartFrame());
872 CodeBreakpoint* bpt = GetCodeBreakpoint(frame->pc()); 872 CodeBreakpoint* bpt = GetCodeBreakpoint(frame->pc());
873 ASSERT(bpt != NULL); 873 ASSERT(bpt != NULL);
874 if (verbose) { 874 if (verbose) {
875 OS::Print(">>> %s breakpoint at %s:%d (Address %p)\n", 875 OS::Print(">>> %s breakpoint at %s:%d (Address %p)\n",
876 bpt->IsInternal() ? "hit internal" : "hit user", 876 bpt->IsInternal() ? "hit internal" : "hit user",
877 bpt ? String::Handle(bpt->SourceUrl()).ToCString() : "?", 877 bpt ? String::Handle(bpt->SourceUrl()).ToCString() : "?",
878 bpt ? bpt->LineNumber() : 0, 878 bpt ? bpt->LineNumber() : 0,
879 frame->pc()); 879 frame->pc());
880 } 880 }
881 DebuggerStackTrace* stack_trace = new DebuggerStackTrace(8); 881 DebuggerStackTrace* stack_trace = new DebuggerStackTrace(8);
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 } 1096 }
1097 1097
1098 1098
1099 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) { 1099 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
1100 ASSERT(bpt->next() == NULL); 1100 ASSERT(bpt->next() == NULL);
1101 bpt->set_next(code_breakpoints_); 1101 bpt->set_next(code_breakpoints_);
1102 code_breakpoints_ = bpt; 1102 code_breakpoints_ = bpt;
1103 } 1103 }
1104 1104
1105 } // namespace dart 1105 } // namespace dart
OLDNEW
« no previous file with comments | « vm/code_generator_x64.cc ('k') | vm/exceptions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698