chrome/browser/ui/browser_init.cc - Issue 10173007: Revert 133740 - Fix homepage migration for users who never changed their settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_init.cc

Issue 10173007: Revert 133740 - Fix homepage migration for users who never changed their settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_init.cc

===================================================================

--- chrome/browser/ui/browser_init.cc (revision 133745)

+++ chrome/browser/ui/browser_init.cc (working copy)

@@ -1194,9 +1194,10 @@

UrlsToTabs(urls, &tabs);

} else if (pref.type == SessionStartupPref::HOMEPAGE) {

- // If 'homepage' selected, either by the user or by a policy, we should

- // have migrated them to another value.

- NOTREACHED() << "SessionStartupPref has deprecated type HOMEPAGE";

+ // If the user had 'homepage' selected, we should have migrated them to

+ // 'URLs' instead.

+ DLOG(ERROR) << "pref.type == HOMEPAGE";

+ NOTREACHED();

}

if (tabs.empty())

« no previous file with comments | « chrome/browser/protector/protected_prefs_watcher.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »