Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: chrome/browser/prefs/pref_service.cc

Issue 10173007: Revert 133740 - Fix homepage migration for users who never changed their settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_service.h ('k') | chrome/browser/prefs/session_startup_pref.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_service.cc
===================================================================
--- chrome/browser/prefs/pref_service.cc (revision 133745)
+++ chrome/browser/prefs/pref_service.cc (working copy)
@@ -684,31 +684,6 @@
return static_cast<const DictionaryValue*>(value);
}
-const base::Value* PrefService::GetUserPrefValue(const char* path) const {
- DCHECK(CalledOnValidThread());
-
- const Preference* pref = FindPreference(path);
- if (!pref) {
- NOTREACHED() << "Trying to get an unregistered pref: " << path;
- return NULL;
- }
-
- // Look for an existing preference in the user store. If it doesn't
- // exist, return NULL.
- base::Value* value = NULL;
- if (user_pref_store_->GetMutableValue(path, &value) !=
- PersistentPrefStore::READ_OK) {
- return NULL;
- }
-
- if (!value->IsType(pref->GetType())) {
- NOTREACHED() << "Pref value type doesn't match registered type.";
- return NULL;
- }
-
- return value;
-}
-
const ListValue* PrefService::GetList(const char* path) const {
DCHECK(CalledOnValidThread());
« no previous file with comments | « chrome/browser/prefs/pref_service.h ('k') | chrome/browser/prefs/session_startup_pref.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698