Issue 10173006: Partial support to IDBKey to Dart conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10173006: Partial support to IDBKey to Dart conversions. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
podivilov

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Partial support to IDBKey to Dart conversions. R=podivilov@chromium.org TEST=client/dom/IndexedBD3Test, partially. Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=443

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
	M	Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp	View	1	1 chunk	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://chromiumcodereview.appspot.com/10173006/diff/1/Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp File Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp (right): https://chromiumcodereview.appspot.com/10173006/diff/1/Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp#newcode83 Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp:83: // FIXME: supprt Array. typo: support

8 years, 8 months ago (2012-04-25 11:06:16 UTC) #2

Anton Muhin

8 years, 8 months ago (2012-04-25 13:16:57 UTC) #3

Thanks a lot for review, landing

https://chromiumcodereview.appspot.com/10173006/diff/1/Source/WebCore/binding...
File Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp (right):

https://chromiumcodereview.appspot.com/10173006/diff/1/Source/WebCore/binding...
Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp:83: // FIXME: supprt
Array.
On 2012/04/25 11:06:16, podivilov wrote:
> typo: support

Done.

Expand Messages | Collapse Messages

Issue 10173006: Partial support to IDBKey to Dart conversions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages