Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1017183002: Add rappor metrics for messages received (Closed)

Created:
5 years, 9 months ago by Miguel Garcia
Modified:
5 years, 9 months ago
Reviewers:
johnme, Steven Holte
CC:
chromium-reviews, peter+watch_chromium.org, johnme+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@raport
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add rappor metrics for messages received BUG=466091 Committed: https://crrev.com/d7cdbb34768054953761fd487fa5165dcb4e6505 Cr-Commit-Position: refs/heads/master@{#321559}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Miguel Garcia
holte for the rappor metric johnme for OWNERS on push_messaging
5 years, 9 months ago (2015-03-18 18:06:20 UTC) #2
johnme
lgtm for push_messaging, once the names match (see below) https://codereview.chromium.org/1017183002/diff/20001/chrome/browser/push_messaging/push_messaging_service_impl.cc File chrome/browser/push_messaging/push_messaging_service_impl.cc (right): https://codereview.chromium.org/1017183002/diff/20001/chrome/browser/push_messaging/push_messaging_service_impl.cc#newcode51 chrome/browser/push_messaging/push_messaging_service_impl.cc:51: ...
5 years, 9 months ago (2015-03-18 18:40:39 UTC) #3
Miguel Garcia
https://codereview.chromium.org/1017183002/diff/20001/chrome/browser/push_messaging/push_messaging_service_impl.cc File chrome/browser/push_messaging/push_messaging_service_impl.cc (right): https://codereview.chromium.org/1017183002/diff/20001/chrome/browser/push_messaging/push_messaging_service_impl.cc#newcode51 chrome/browser/push_messaging/push_messaging_service_impl.cc:51: On 2015/03/18 18:40:39, johnme wrote: > Nit: no double ...
5 years, 9 months ago (2015-03-18 18:51:28 UTC) #4
Steven Holte
rappor code lgtm
5 years, 9 months ago (2015-03-18 21:18:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017183002/40001
5 years, 9 months ago (2015-03-20 11:25:46 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 12:30:01 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 12:31:11 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d7cdbb34768054953761fd487fa5165dcb4e6505
Cr-Commit-Position: refs/heads/master@{#321559}

Powered by Google App Engine
This is Rietveld 408576698