Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: content/browser/site_instance_impl_unittest.cc

Issue 10171018: Create swapped-out opener RVHs after a process swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove parameter comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/site_instance_impl.cc ('k') | content/browser/web_contents/interstitial_page_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/site_instance_impl_unittest.cc
diff --git a/content/browser/site_instance_impl_unittest.cc b/content/browser/site_instance_impl_unittest.cc
index fec7c79e007a3cba3040c172e0b89b5cb14d74a9..fcda84aaf24bcf862b537e6a19165d9bb254159a 100644
--- a/content/browser/site_instance_impl_unittest.cc
+++ b/content/browser/site_instance_impl_unittest.cc
@@ -251,11 +251,8 @@ TEST_F(SiteInstanceTest, SiteInstanceDestructor) {
&site_delete_counter,
&browsing_delete_counter);
{
- WebContentsImpl web_contents(browser_context.get(),
- instance,
- MSG_ROUTING_NONE,
- NULL,
- NULL);
+ WebContentsImpl web_contents(browser_context.get(), instance,
+ MSG_ROUTING_NONE, NULL, NULL, NULL);
EXPECT_EQ(1, site_delete_counter);
EXPECT_EQ(1, browsing_delete_counter);
}
@@ -416,6 +413,7 @@ TEST_F(SiteInstanceTest, OneSiteInstancePerSite) {
static_cast<SiteInstanceImpl*>(
browsing_instance->GetSiteInstanceForURL(url_b1)));
EXPECT_NE(site_instance_a1.get(), site_instance_b1.get());
+ EXPECT_TRUE(site_instance_a1->IsRelatedSiteInstance(site_instance_b1));
// Getting the new SiteInstance from the BrowsingInstance and from another
// SiteInstance in the BrowsingInstance should give the same result.
@@ -439,6 +437,7 @@ TEST_F(SiteInstanceTest, OneSiteInstancePerSite) {
static_cast<SiteInstanceImpl*>(
browsing_instance2->GetSiteInstanceForURL(url_a2)));
EXPECT_NE(site_instance_a1.get(), site_instance_a2_2.get());
+ EXPECT_FALSE(site_instance_a1->IsRelatedSiteInstance(site_instance_a2_2));
// Should be able to see that we do have SiteInstances.
EXPECT_TRUE(browsing_instance->HasSiteInstance(
@@ -477,6 +476,7 @@ TEST_F(SiteInstanceTest, OneSiteInstancePerSiteInBrowserContext) {
static_cast<SiteInstanceImpl*>(
browsing_instance->GetSiteInstanceForURL(url_b1)));
EXPECT_NE(site_instance_a1.get(), site_instance_b1.get());
+ EXPECT_TRUE(site_instance_a1->IsRelatedSiteInstance(site_instance_b1));
// Getting the new SiteInstance from the BrowsingInstance and from another
// SiteInstance in the BrowsingInstance should give the same result.
« no previous file with comments | « content/browser/site_instance_impl.cc ('k') | content/browser/web_contents/interstitial_page_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698