Issue 10171013: TSAN: Exclude a couple tests that are failing / timing out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10171013: TSAN: Exclude a couple tests that are failing / timing out. (Closed)

Created:
8 years, 8 months ago by Lei Zhang

Modified:
8 years, 8 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

TSAN: Exclude a couple tests that are failing / timing out. BUG=119467, 124452 TEST=none TBR=timurrrr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133267

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tools/valgrind/gtest_exclude/sync_unit_tests.gtest-tsan.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

8 years, 8 months ago (2012-04-23 19:19:41 UTC) #2

LGTM

On Sat, Apr 21, 2012 at 12:41 AM,  <thestig@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov,
>
> Description:
> TSAN: Exclude a couple tests that are failing / timing out.
>
> BUG=119467,124452
> TEST=none
> TBR=timurrrr
>
> Please review this at https://chromiumcodereview.appspot.com/10171013/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
>  M     tools/valgrind/gtest_exclude/sync_unit_tests.gtest-tsan.txt
>
>
> Index: tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> (revision 133232)
> +++ tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> (working copy)
> @@ -39,3 +39,6 @@
>
>  # See http://crbug.com/50346
>  DiskCacheEntryTest.*
> +
> +# Times out occasionally, http://crbug.com/124452
> +HostResolverImplTest.StartWithinCallback
> Index: tools/valgrind/gtest_exclude/sync_unit_tests.gtest-tsan.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/sync_unit_tests.gtest-tsan.txt (revision
> 133232)
> +++ tools/valgrind/gtest_exclude/sync_unit_tests.gtest-tsan.txt (working
> copy)
> @@ -1,2 +1,5 @@
>  # Flaky, see http://crbug.com/118370
>  SyncSchedulerTest.TransientPollFailure
> +
> +# Flaky, http://crbug.com/119467
> +InvalidationNotifierTest.Basic
>
>

Expand Messages | Collapse Messages