Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 10170045: Fix HtmlDialog typos. (Closed)

Created:
8 years, 8 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_render_watcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 8 months ago (2012-04-28 02:16:37 UTC) #1
Ben Goodger (Google)
8 years, 7 months ago (2012-04-28 14:29:03 UTC) #2
lgtm

On Fri, Apr 27, 2012 at 7:16 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fix HtmlDialog typos.
>
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10170045/<http://codereview.chromium.org/101...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/printing/print_**dialog_cloud.cc
>  M chrome/browser/tab_render_**watcher_browsertest.cc
>  M chrome/common/chrome_**notification_types.h
>
>
> Index: chrome/browser/printing/print_**dialog_cloud.cc
> diff --git a/chrome/browser/printing/**print_dialog_cloud.cc
> b/chrome/browser/printing/**print_dialog_cloud.cc
> index c6a6e24ead85f675b094e62b8ea4ce**14e729bd3c..**
> f13caf62f44de239be18bba1decf36**ce30e36b60 100644
> --- a/chrome/browser/printing/**print_dialog_cloud.cc
> +++ b/chrome/browser/printing/**print_dialog_cloud.cc
> @@ -75,14 +75,14 @@
>  // show an HTML dialog using that class as the delegate. That class
>  // hands in the kChromeUICloudPrintResourcesUR**L as the URL to visit.
>  That is
>  // recognized by the GetWebUIFactoryFunction as a signal to create an
> -// ExternalHtmlDialogUI.
> +// ExternalWebDialogUI.
>
>  // CloudPrintWebDialogDelegate also temporarily owns a
>  // CloudPrintFlowHandler, a class which is responsible for the actual
>  // interactions with the dialog contents, including handing in the
>  // print data and getting any page setup parameters that the dialog
>  // contents provides.  As part of bringing up the dialog,
> -// HtmlDialogUI::**RenderViewCreated is called (an override of
> +// WebDialogUI::RenderViewCreated is called (an override of
>  // WebUI::RenderViewCreated).  That routine, in turn, calls the
>  // delegate's GetWebUIMessageHandlers routine, at which point the
>  // ownership of the CloudPrintFlowHandler is handed over.  A pointer
> Index: chrome/browser/tab_render_**watcher_browsertest.cc
> diff --git a/chrome/browser/tab_render_**watcher_browsertest.cc
> b/chrome/browser/tab_render_**watcher_browsertest.cc
> index d488b12b79e226cef721c42f82e76d**03134fb8e9..**
> ee7148cda7fa635476b2770657d690**d79f0576ea 100644
> --- a/chrome/browser/tab_render_**watcher_browsertest.cc
> +++ b/chrome/browser/tab_render_**watcher_browsertest.cc
> @@ -57,7 +57,7 @@ class TabRenderWatcherTest : public InProcessBrowserTest,
>   bool main_frame_rendered_;
>  };
>
> -// Migrated from HtmlDialogBrowserTest.**TestStateTransition, which
> times out
> +// Migrated from WebDialogBrowserTest.**TestStateTransition, which times
> out
>  // about 5~10% of runs. See crbug.com/86059.
>  IN_PROC_BROWSER_TEST_F(**TabRenderWatcherTest,
> DISABLED_TestStateTransition) {
>   views::WebView* webview = new views::WebView(browser()->**profile());
> Index: chrome/common/chrome_**notification_types.h
> diff --git a/chrome/common/chrome_**notification_types.h
> b/chrome/common/chrome_**notification_types.h
> index b4827163405f6ea3af4b2884e8fde1**ac4fc7d350..**
> 697264f06a775e565caa0f2941d3d3**18fa1a8c2c 100644
> --- a/chrome/common/chrome_**notification_types.h
> +++ b/chrome/common/chrome_**notification_types.h
> @@ -79,7 +79,7 @@ enum NotificationType {
>   // traversal. The source is the browser, there are no details.
>   NOTIFICATION_FOCUS_RETURNED_**TO_BROWSER,
>
> -  // Sent after an HtmlDialog dialog has been shown. The source is the
> +  // Sent after an WebDialog dialog has been shown. The source is the
>   // dialog. The details is a Details<RenderViewHost> with a pointer to
> the RVH
>   // for the shown dialog.
>   NOTIFICATION_HTML_DIALOG_**SHOWN,
>
>
>

Powered by Google App Engine
This is Rietveld 408576698