Apps shouldn't disappear from pinned list after update

Apps shouldn't disappear from pinned list after update

If pinned app is unloaded, put it to pending_pinned_apps_ list and pin it again when it is loaded again.

BUG=123293
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134788

[xiyuan, 2012-04-27 15:53:18]

LGTM

https://chromiumcodereview.appspot.com/10170029/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc (right):

https://chromiumcodereview.appspot.com/10170029/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc:555:
UnpinAppsWithID(extension->id());
nit: We could move this into the above "if" since we only need to unpin for
pinned apps.

[Dmitry Polukhin, 2012-04-27 18:17:04]

https://chromiumcodereview.appspot.com/10170029/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc (right):

https://chromiumcodereview.appspot.com/10170029/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc:555:
UnpinAppsWithID(extension->id());
On 2012/04/27 15:53:18, xiyuan wrote:
> nit: We could move this into the above "if" since we only need to unpin for
> pinned apps.

Done.

[commit-bot: I haz the power, 2012-04-27 18:18:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10170029/7001

[commit-bot: I haz the power, 2012-04-27 18:18:47]

Presubmit check for 10170029-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/views/ash/launcher

[Dmitry Polukhin, 2012-04-27 18:20:21]

+Dave for owner review

[Dmitry Polukhin, 2012-05-01 17:46:10]

+ derat@ and sky@ for OWNERS review.

[sky, 2012-05-01 18:16:30]

LGTM

[commit-bot: I haz the power, 2012-05-01 19:43:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10170029/7001

[commit-bot: I haz the power, 2012-05-01 21:45:27]

Change committed as 134788