Replace const char* in cros_network_functions.h with const std::stirng&

Replace const char* in cros_network_functions.h with const std::stirng&

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133369

[hashimoto, 2012-04-20 14:08:43]

const char* is prone of resource lifetime bug.
NULL check in NetworkLibraryImplCros::WifiServiceUpdateAndConnect and other
places are removed since Libcros never passes NULL for those callbacks.

[stevenjb, 2012-04-20 17:18:28]

A couple of questions about the test code, but LGTM either way.

http://codereview.chromium.org/10170003/diff/6/chrome/browser/chromeos/cros/c...
File chrome/browser/chromeos/cros/cros_network_functions_unittest.cc (right):

http://codereview.chromium.org/10170003/diff/6/chrome/browser/chromeos/cros/c...
chrome/browser/chromeos/cros/cros_network_functions_unittest.cc:215: const char
property[] = "property";
Shouldn't we use std::string here and elsewhere?

http://codereview.chromium.org/10170003/diff/6/chrome/browser/chromeos/cros/c...
chrome/browser/chromeos/cros/cros_network_functions_unittest.cc:307:
MonitorNetworkServiceProperties(_, StrEq(path.c_str()), _))
Do we need to use StrEq and .c_str() here and elsewhere?

[hashimoto, 2012-04-22 05:44:50]

http://codereview.chromium.org/10170003/diff/6/chrome/browser/chromeos/cros/c...
File chrome/browser/chromeos/cros/cros_network_functions_unittest.cc (right):

http://codereview.chromium.org/10170003/diff/6/chrome/browser/chromeos/cros/c...
chrome/browser/chromeos/cros/cros_network_functions_unittest.cc:215: const char
property[] = "property";
On 2012/04/20 17:18:28, stevenjb (chromium) wrote:
> Shouldn't we use std::string here and elsewhere?

Sounds good.
Done.

http://codereview.chromium.org/10170003/diff/6/chrome/browser/chromeos/cros/c...
chrome/browser/chromeos/cros/cros_network_functions_unittest.cc:307:
MonitorNetworkServiceProperties(_, StrEq(path.c_str()), _))
On 2012/04/20 17:18:28, stevenjb (chromium) wrote:
> Do we need to use StrEq and .c_str() here and elsewhere?

I didn't know that StrEq can take a std::string as an argument, thanks.
Done.