Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: content/public/browser/devtools_http_handler.h

Issue 10169043: Allow customization of remote debugger URL targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_http_handler.h
===================================================================
--- content/public/browser/devtools_http_handler.h (revision 133430)
+++ content/public/browser/devtools_http_handler.h (working copy)
@@ -17,12 +17,26 @@
namespace content {
class DevToolsHttpHandlerDelegate;
+class RenderViewHost;
// This class is used for managing DevTools remote debugging server.
// Clients can connect to the specified ip:port and start debugging
// this browser.
class DevToolsHttpHandler {
public:
+ // Interface responsible for mapping RenderViewHost instances to/from string
+ // identifiers.
+ class RenderViewHostBinding {
+ public:
+ virtual ~RenderViewHostBinding() {}
+
+ // Returns the mapping of RenderViewHost to identifier.
+ virtual std::string GetIdentifier(RenderViewHost* rvh) = 0;
+
+ // Return the mapping of identifier to RenderViewHost.
pfeldman 2012/04/25 15:27:54 Returns
Marshall 2012/04/25 15:36:19 Done.
+ virtual RenderViewHost* ForIdentifier(const std::string& identifier) = 0;
+ };
+
// Returns frontend resource id for the given resource |name|.
CONTENT_EXPORT static int GetFrontendResourceId(
const std::string& name);
@@ -39,6 +53,10 @@
// Automatically destroys the handler instance.
virtual void Stop() = 0;
+ // Set the RenderViewHostBinding instance. If no instance is provided the
+ // default implementation will be used.
+ virtual void SetRenderViewHostBinding(RenderViewHostBinding* binding) = 0;
+
protected:
virtual ~DevToolsHttpHandler() {}
};

Powered by Google App Engine
This is Rietveld 408576698