Move the rest of the Flash functions to the thunk system.

Move the rest of the Flash functions to the thunk system.

This removes the manual Flash interface registration and adds them via the
interfaces_ppb_private_flash.h header. I moved File_ModulalLocal and
File_FileRef to the Flash API virtual interface which allowed me to delete
the separate proxies and stuff associated with those interfaces.

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134540

[brettw, 2012-04-24 22:48:46]

This is the final pass of Flash interface registration & routing normalization.

https://chromiumcodereview.appspot.com/10169040/diff/1/ppapi/proxy/ppb_flash_...
File ppapi/proxy/ppb_flash_proxy.cc (right):

https://chromiumcodereview.appspot.com/10169040/diff/1/ppapi/proxy/ppb_flash_...
ppapi/proxy/ppb_flash_proxy.cc:40: IPC::PlatformFileForTransit
PlatformFileToPlatformFileForTransit(
This stuff was just moved from the file_proxy.cc

https://chromiumcodereview.appspot.com/10169040/diff/1/webkit/plugins/ppapi/p...
File webkit/plugins/ppapi/ppb_flash_impl.cc (right):

https://chromiumcodereview.appspot.com/10169040/diff/1/webkit/plugins/ppapi/p...
webkit/plugins/ppapi/ppb_flash_impl.cc:376: bool
PPB_Flash_Impl::CreateThreadAdapterForInstance(PP_Instance instance) {
This was just copied from the flash_file_impl

[yzshen1, 2012-04-25 20:50:47]

http://codereview.chromium.org/10169040/diff/1/ppapi/proxy/ppb_flash_proxy.cc
File ppapi/proxy/ppb_flash_proxy.cc (right):

http://codereview.chromium.org/10169040/diff/1/ppapi/proxy/ppb_flash_proxy.cc...
ppapi/proxy/ppb_flash_proxy.cc:56: : public
base::RefCountedThreadSafe<ModuleLocalThreadAdapter> {
Please include .h for things such as RefCountedThreadSafe,
ChannelProxy::MessageFilter, set, map, Lock, etc.

http://codereview.chromium.org/10169040/diff/1/ppapi/proxy/ppb_flash_proxy.cc...
ppapi/proxy/ppb_flash_proxy.cc:736:
PpapiGlobals::Get()->GetResourceTracker()->GetResource(file_ref_id);
Can we use EnterResourceNoLock? (And also line 757.)

http://codereview.chromium.org/10169040/diff/1/ppapi/proxy/ppb_flash_proxy.cc...
ppapi/proxy/ppb_flash_proxy.cc:740: PluginDispatcher* dispatcher =
PluginDispatcher::GetForResource(file_ref);
Can we use dispatcher() here? (And also line 761.)

http://codereview.chromium.org/10169040/diff/1/ppapi/proxy/ppb_flash_proxy.cc...
ppapi/proxy/ppb_flash_proxy.cc:1010: if (enter.succeeded()) {
Please set |result| if enter.failed() here and some other places below.

http://codereview.chromium.org/10169040/diff/1/ppapi/thunk/ppb_flash_file_fil...
File ppapi/thunk/ppb_flash_file_fileref_thunk.cc (right):

http://codereview.chromium.org/10169040/diff/1/ppapi/thunk/ppb_flash_file_fil...
ppapi/thunk/ppb_flash_file_fileref_thunk.cc:7: #include "ppapi/thunk/thunk.h"
sort this section, please.

http://codereview.chromium.org/10169040/diff/1/ppapi/thunk/ppb_flash_file_mod...
File ppapi/thunk/ppb_flash_file_modulelocal_thunk.cc (right):

http://codereview.chromium.org/10169040/diff/1/ppapi/thunk/ppb_flash_file_mod...
ppapi/thunk/ppb_flash_file_modulelocal_thunk.cc:7: #include
"ppapi/thunk/thunk.h"
Sort this section, please.

http://codereview.chromium.org/10169040/diff/1/ppapi/thunk/ppb_flash_file_mod...
ppapi/thunk/ppb_flash_file_modulelocal_thunk.cc:20: return PP_FALSE;
The return value is bool.

http://codereview.chromium.org/10169040/diff/1/ppapi/thunk/ppb_flash_file_mod...
ppapi/thunk/ppb_flash_file_modulelocal_thunk.cc:77: int32_t
GetDirContents(PP_Instance instance, const char* path,
Please put each parameter on a separate line.

http://codereview.chromium.org/10169040/diff/1/webkit/plugins/ppapi/ppb_flash...
File webkit/plugins/ppapi/ppb_flash_impl.cc (right):

http://codereview.chromium.org/10169040/diff/1/webkit/plugins/ppapi/ppb_flash...
webkit/plugins/ppapi/ppb_flash_impl.cc:525: EnterResource<PPB_FileRef_API>
enter(file_ref_id, true);
Here and line 546: Is it EnterResourceNoLock?

[brettw, 2012-04-26 21:24:13]

I think I got all your comments, thanks!

[yzshen1, 2012-04-26 21:47:07]

LGTM with a nit.

http://codereview.chromium.org/10169040/diff/8001/ppapi/thunk/ppb_flash_file_...
File ppapi/thunk/ppb_flash_file_modulelocal_thunk.cc (right):

http://codereview.chromium.org/10169040/diff/8001/ppapi/thunk/ppb_flash_file_...
ppapi/thunk/ppb_flash_file_modulelocal_thunk.cc:7: #include
"ppapi/thunk/thunk.h"
Please sort this section.