Issue 10169007: Add missing named fields to SharedFunctionInfo in heap snapshot.

Issue 10169007: Add missing named fields to SharedFunctionInfo in heap snapshot. (Closed)

Created:
8 years, 8 months ago by alexeif

Modified:
8 years, 8 months ago

Reviewers:
mnaganov (inactive), yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add missing named fields to SharedFunctionInfo in heap snapshot. Committed: https://code.google.com/p/v8/source/detail?r=11403

Patch Set 2 : Addressing comments. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	src/profile-generator.cc	View	1	3 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc#newcode2099 src/profile-generator.cc:2099: TagObject(shared->unchecked_code(), "(code)"); Why not shared->code() ? https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc#newcode2117 src/profile-generator.cc:2117: SetInternalReference(obj, ...

8 years, 8 months ago (2012-04-20 13:14:08 UTC) #2

mnaganov (inactive)

LGTM https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc#newcode2099 src/profile-generator.cc:2099: TagObject(shared->unchecked_code(), "(code)"); I think, SFI doesn't always contain ...

8 years, 8 months ago (2012-04-20 13:38:25 UTC) #3

alexeif

https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc#newcode2099 src/profile-generator.cc:2099: TagObject(shared->unchecked_code(), "(code)"); On 2012/04/20 13:14:08, Yury Semikhatsky wrote: > ...

8 years, 8 months ago (2012-04-20 13:51:33 UTC) #5

mnaganov (inactive)

8 years, 8 months ago (2012-04-20 14:00:33 UTC) #6

On 2012/04/20 13:51:33, alexeif wrote:
>
https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator.cc
> File src/profile-generator.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10169007/diff/1/src/profile-generator....
> src/profile-generator.cc:2099: TagObject(shared->unchecked_code(), "(code)");
> On 2012/04/20 13:14:08, Yury Semikhatsky wrote:
> > Why not shared->code() ?
> I don't know. overcautiousness ;-)
> Fixed.

LGTM

Expand Messages | Collapse Messages