Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: frog/tests/leg/src/BuiltinInterceptorTest.dart

Issue 10168009: Revert "Only emit typeguards if we think they are valuable." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | frog/tests/leg/src/CodeMotionTest.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #import("compiler_helper.dart"); 5 #import("compiler_helper.dart");
6 6
7 final String TEST_ONE = @""" 7 final String TEST_ONE = @"""
8 foo(String a) { 8 foo(String a) {
9 // index into the parameter and move into a loop to make sure we'll get a 9 // index into the parameter to make sure we'll get a type guard.
10 // type guard. 10 print(a[0]);
11 for (int i = 0; i < 1; i++) {
12 print(a[0]);
13 }
14 return a.length; 11 return a.length;
15 } 12 }
16 """; 13 """;
17 14
18 final String TEST_TWO = @""" 15 final String TEST_TWO = @"""
19 foo() { 16 foo() {
20 return "foo".length; 17 return "foo".length;
21 } 18 }
22 """; 19 """;
23 20
(...skipping 15 matching lines...) Expand all
39 36
40 generated = compile(TEST_TWO, 'foo'); 37 generated = compile(TEST_TWO, 'foo');
41 Expect.isTrue(generated.contains("return 3;")); 38 Expect.isTrue(generated.contains("return 3;"));
42 39
43 generated = compile(TEST_THREE, 'foo'); 40 generated = compile(TEST_THREE, 'foo');
44 Expect.isTrue(generated.contains("return 3;")); 41 Expect.isTrue(generated.contains("return 3;"));
45 42
46 generated = compile(TEST_FOUR, 'foo'); 43 generated = compile(TEST_FOUR, 'foo');
47 Expect.isTrue(generated.contains("push(2);")); 44 Expect.isTrue(generated.contains("push(2);"));
48 } 45 }
OLDNEW
« no previous file with comments | « no previous file | frog/tests/leg/src/CodeMotionTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698