Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: ipc/ipc_channel_nacl.cc

Issue 10167024: Add ipc_channel_nacl to the untrusted build and fix all compile/link errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_nacl.h ('k') | ipc/ipc_channel_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_nacl.cc
===================================================================
--- ipc/ipc_channel_nacl.cc (revision 133452)
+++ ipc/ipc_channel_nacl.cc (working copy)
@@ -12,62 +12,80 @@
namespace IPC {
-ChannelImpl::ChannelImpl(const IPC::ChannelHandle& channel_handle,
+Channel::ChannelImpl::ChannelImpl(const IPC::ChannelHandle& channel_handle,
Mode mode,
Listener* listener)
: ChannelReader(listener) {
}
-ChannelImpl::~ChannelImpl() {
+Channel::ChannelImpl::~ChannelImpl() {
Close();
}
-bool ChannelImpl::Connect() {
+bool Channel::ChannelImpl::Connect() {
NOTIMPLEMENTED();
return false;
}
-void ChannelImpl::Close() {
+void Channel::ChannelImpl::Close() {
NOTIMPLEMENTED();
}
-bool ChannelImpl::Send(Message* message) {
+bool Channel::ChannelImpl::Send(Message* message) {
NOTIMPLEMENTED();
}
-int ChannelImpl::GetClientFileDescriptor() const {
+int Channel::ChannelImpl::GetClientFileDescriptor() const {
NOTIMPLEMENTED();
return -1;
}
-int ChannelImpl::TakeClientFileDescriptor() {
+int Channel::ChannelImpl::TakeClientFileDescriptor() {
NOTIMPLEMENTED();
return -1;
}
-bool ChannelImpl::AcceptsConnections() const {
+bool Channel::ChannelImpl::AcceptsConnections() const {
NOTIMPLEMENTED();
return false;
}
-bool ChannelImpl::HasAcceptedConnection() const {
+bool Channel::ChannelImpl::HasAcceptedConnection() const {
NOTIMPLEMENTED();
return false;
}
-bool ChannelImpl::GetClientEuid(uid_t* client_euid) const {
+bool Channel::ChannelImpl::GetClientEuid(uid_t* client_euid) const {
NOTIMPLEMENTED();
return false;
}
-void ChannelImpl::ResetToAcceptingConnectionState() {
+void Channel::ChannelImpl::ResetToAcceptingConnectionState() {
NOTIMPLEMENTED();
}
+Channel::ChannelImpl::ReadState
+ Channel::ChannelImpl::ReadData(char* buffer,
brettw 2012/04/23 21:17:35 I think generally we wouldn't indent this second l
+ int buffer_len,
+ int* bytes_read) {
+ return Channel::ChannelImpl::ReadState();
+}
+
+bool Channel::ChannelImpl::WillDispatchInputMessage(Message* msg) {
+ return false;
+}
+
+bool Channel::ChannelImpl::DidEmptyInputBuffers() {
+ return false;
+}
+
+void Channel::ChannelImpl::HandleHelloMessage(const Message& msg) {
+}
+
// static
bool Channel::ChannelImpl::IsNamedServerInitialized(
const std::string& channel_id) {
- return file_util::PathExists(FilePath(channel_id));
+ return false; //file_util::PathExists(FilePath(channel_id));
}
//------------------------------------------------------------------------------
@@ -123,6 +141,8 @@
channel_impl_->ResetToAcceptingConnectionState();
}
+base::ProcessId Channel::peer_pid() const { return 0; }
brettw 2012/04/23 21:17:35 I'd do multiple lines except for some cases in a c
+
// static
bool Channel::IsNamedServerInitialized(const std::string& channel_id) {
return ChannelImpl::IsNamedServerInitialized(channel_id);
« no previous file with comments | « ipc/ipc_channel_nacl.h ('k') | ipc/ipc_channel_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698