Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: src/profile-generator.cc

Issue 10167013: Exclude filler maps from object properties in heap snapshot. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2472 matching lines...) Expand 10 before | Expand all | Expand 10 after
2483 bool V8HeapExplorer::IsEssentialObject(Object* object) { 2483 bool V8HeapExplorer::IsEssentialObject(Object* object) {
2484 // We have to use raw_unchecked_* versions because checked versions 2484 // We have to use raw_unchecked_* versions because checked versions
2485 // would fail during iteration over object properties. 2485 // would fail during iteration over object properties.
2486 return object->IsHeapObject() 2486 return object->IsHeapObject()
2487 && !object->IsOddball() 2487 && !object->IsOddball()
2488 && object != heap_->raw_unchecked_empty_byte_array() 2488 && object != heap_->raw_unchecked_empty_byte_array()
2489 && object != heap_->raw_unchecked_empty_fixed_array() 2489 && object != heap_->raw_unchecked_empty_fixed_array()
2490 && object != heap_->raw_unchecked_empty_descriptor_array() 2490 && object != heap_->raw_unchecked_empty_descriptor_array()
2491 && object != heap_->raw_unchecked_fixed_array_map() 2491 && object != heap_->raw_unchecked_fixed_array_map()
2492 && object != heap_->raw_unchecked_global_property_cell_map() 2492 && object != heap_->raw_unchecked_global_property_cell_map()
2493 && object != heap_->raw_unchecked_shared_function_info_map(); 2493 && object != heap_->raw_unchecked_shared_function_info_map()
2494 && object != heap_->raw_unchecked_free_space_map()
2495 && object != heap_->raw_unchecked_one_pointer_filler_map()
2496 && object != heap_->raw_unchecked_two_pointer_filler_map();
2494 } 2497 }
2495 2498
2496 2499
2497 void V8HeapExplorer::SetClosureReference(HeapObject* parent_obj, 2500 void V8HeapExplorer::SetClosureReference(HeapObject* parent_obj,
2498 HeapEntry* parent_entry, 2501 HeapEntry* parent_entry,
2499 String* reference_name, 2502 String* reference_name,
2500 Object* child_obj) { 2503 Object* child_obj) {
2501 HeapEntry* child_entry = GetEntry(child_obj); 2504 HeapEntry* child_entry = GetEntry(child_obj);
2502 if (child_entry != NULL) { 2505 if (child_entry != NULL) {
2503 filler_->SetNamedReference(HeapGraphEdge::kContextVariable, 2506 filler_->SetNamedReference(HeapGraphEdge::kContextVariable,
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
3954 3957
3955 3958
3956 void HeapSnapshotJSONSerializer::SortHashMap( 3959 void HeapSnapshotJSONSerializer::SortHashMap(
3957 HashMap* map, List<HashMap::Entry*>* sorted_entries) { 3960 HashMap* map, List<HashMap::Entry*>* sorted_entries) {
3958 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p)) 3961 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p))
3959 sorted_entries->Add(p); 3962 sorted_entries->Add(p);
3960 sorted_entries->Sort(SortUsingEntryValue); 3963 sorted_entries->Sort(SortUsingEntryValue);
3961 } 3964 }
3962 3965
3963 } } // namespace v8::internal 3966 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698