Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 10167012: Scons: Move some library dependency declarations into library_deps.py (Closed)

Created:
8 years, 8 months ago by Mark Seaborn
Modified:
8 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Scons: Move some library dependency declarations into library_deps.py Declare dependencies of the 'sel' library in order to fix some of the worst duplication. Change the code in library_deps.py to take dependencies for 'sel' from both LIBRARY_DEPENDENCIES_DEFAULT and PLATFORM_LIBRARY_DEPENDENCIES. Replace the transitive-closure implementation in library_deps.py with one that is simpler and easier to understand. BUG=none TEST=build Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8348

Patch Set 1 #

Patch Set 2 : Tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -182 lines) Patch
M site_scons/site_tools/library_deps.py View 1 4 chunks +47 lines, -59 lines 0 comments Download
M tests/custom_desc/nacl.scons View 1 chunk +1 line, -21 lines 0 comments Download
M tests/minnacl/nacl.scons View 1 chunk +1 line, -21 lines 0 comments Download
M tests/multiple_sandboxes/nacl.scons View 1 chunk +1 line, -21 lines 0 comments Download
M tests/trusted_crash/osx_crash_filter/nacl.scons View 1 chunk +1 line, -21 lines 0 comments Download
M tests/trusted_crash/osx_crash_forwarding/nacl.scons View 1 chunk +1 line, -21 lines 0 comments Download
M tests/trusted_crash/win_crash_in_syscall/nacl.scons View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
8 years, 8 months ago (2012-04-20 19:54:08 UTC) #1
Nick Bray (chromium)
8 years, 8 months ago (2012-04-20 21:05:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698