Sync: Prevent delay in showing the Other Devices button after first sign-in

Sync: Prevent delay in showing the Other Devices button after first sign-in.

BUG=123033
TEST=In a signed-in profile, open a new tab page. Then open
chrome://settings/syncSetup in another tab. Toggle the "Open Tabs" sync option,
then observe that the "Other devices" menu appears or disappears from the NTP
as appropriate.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133522

[Patrick Dubroy, 2012-04-20 09:18:41]

PTAL -- zea for correctness, dbeam for OWNERS rubber stamp.

[Nicolas Zea, 2012-04-20 17:20:17]

This is still racy w.r.t. the sync service standing up though right?

Also, is the problem that listening to the notifications for
SYNC_CONFIGURE_DONE, FOREIGN_SESSION_UPDATED, not trigger an NTP re-render?

[Patrick Dubroy, 2012-04-23 09:49:46]

On 2012/04/20 17:20:17, nzea wrote:
> This is still racy w.r.t. the sync service standing up though right?
> 
> Also, is the problem that listening to the notifications for
> SYNC_CONFIGURE_DONE, FOREIGN_SESSION_UPDATED, not trigger an NTP re-render?

Yeah, you're right on both counts. Listening on AllSources() fixes the problem
though.

I think we still want to check that the datatype is enabled, rather than just
calling GetSessionModelAssociator(), because that will return NULL unless the
associator is in the RUNNING state:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/sync/profil....

[Patrick Dubroy, 2012-04-23 09:50:34]

Ok, I think this is the correct fix.

[Nicolas Zea, 2012-04-23 18:18:52]

http://codereview.chromium.org/10167001/diff/11001/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/foreign_session_handler.cc (right):

http://codereview.chromium.org/10167001/diff/11001/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/foreign_session_handler.cc:66:
content::NotificationService::AllSources());
This is going to listen to other profiles as well (in a multi-profile environ).
Are you sure that's what you want?

[Nicolas Zea, 2012-04-23 18:39:59]

discussed offline, this is the simplest fix for now.
LGTM

[Dan Beam, 2012-04-23 18:43:50]

lgtm