Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10166022: PRESUBMIT.py files are not executable. (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

PRESUBMIT.py files are not executable. R=sadrul@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A ui/views/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
8 years, 8 months ago (2012-04-21 02:26:02 UTC) #1
sadrul
lgtm
8 years, 8 months ago (2012-04-21 13:57:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10166022/1
8 years, 8 months ago (2012-04-21 15:07:12 UTC) #3
commit-bot: I haz the power
Try job failure for 10166022-1 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...
8 years, 8 months ago (2012-04-21 19:14:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10166022/1
8 years, 8 months ago (2012-04-23 01:51:02 UTC) #5
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
8 years, 8 months ago (2012-04-23 03:03:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10166022/1
8 years, 8 months ago (2012-04-23 12:59:02 UTC) #7
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
8 years, 8 months ago (2012-04-23 14:43:37 UTC) #8
M-A Ruel
8 years, 8 months ago (2012-04-23 14:45:41 UTC) #9
On 2012/04/23 14:43:37, I haz the power (commit-bot) wrote:
> Commit queue had an internal error.
> Something went really wrong, probably a crash, a hickup or
> simply the monkeys went out for dinner.
> The relevant dude was pinged already.

The CQ hates CLs without file content. Committing manually.

Powered by Google App Engine
This is Rietveld 408576698