Add names to GlobalObject inline properties in heap snapshot.

src/profile-generator.cc

Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index f722795f4857d73e75616f02d4929abf4b8e3e03..94317c7d9cbd6e139844cdf2579847d95c60c2c1 100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -2037,6 +2037,17 @@ void V8HeapExplorer::ExtractReferences(HeapObject* obj) {
            i += kPointerSize) {
         SetWeakReference(js_fun, entry, i, *HeapObject::RawField(js_fun, i), i);
       }
+    } else if (obj->IsGlobalObject()) {
+      GlobalObject* global_obj = GlobalObject::cast(obj);
+      SetInternalReference(global_obj, entry,
+                           "builtins", global_obj->builtins(),
+                           GlobalObject::kBuiltinsOffset);
+      SetInternalReference(global_obj, entry,
+                           "global_context", global_obj->global_context(),
+                           GlobalObject::kGlobalContextOffset);
+      SetInternalReference(global_obj, entry,

[yurys, 2012/04/23 05:36:18]

Is it possible to merge such objects into the global one (in the snapshot) to
avoid user confusion?

[alexeif, 2012/04/23 15:23:43]

Could you please elaborate?

[yurys, 2012/04/24 08:38:50]

I meant that it may be hard to explain to the user what things like
global_receiver on the global object are. I understand that it is accurate
representation of what's going on under the hood but since we are trying to
filter out some internal objects that would make sense to fix things like this
as well.

+                           "global_receiver", global_obj->global_receiver(),
+                           GlobalObject::kGlobalReceiverOffset);
     }
     TagObject(js_obj->properties(), "(object properties)");
     SetInternalReference(obj, entry,