Add names to GlobalObject inline properties in heap snapshot.

Add names to GlobalObject inline properties in heap snapshot.

Committed: https://code.google.com/p/v8/source/detail?r=11410

[mnaganov (inactive), 2012-04-20 19:19:49]

lgtm

[yurys, 2012-04-23 05:36:18]

https://chromiumcodereview.appspot.com/10166007/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10166007/diff/1/src/profile-generator....
src/profile-generator.cc:2048: SetInternalReference(global_obj, entry,
Is it possible to merge such objects into the global one (in the snapshot) to
avoid user confusion?

[alexeif, 2012-04-23 15:23:43]

https://chromiumcodereview.appspot.com/10166007/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10166007/diff/1/src/profile-generator....
src/profile-generator.cc:2048: SetInternalReference(global_obj, entry,
On 2012/04/23 05:36:18, Yury Semikhatsky wrote:
> Is it possible to merge such objects into the global one (in the snapshot) to
> avoid user confusion?
Could you please elaborate?

[yurys, 2012-04-24 08:38:50]

https://chromiumcodereview.appspot.com/10166007/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10166007/diff/1/src/profile-generator....
src/profile-generator.cc:2048: SetInternalReference(global_obj, entry,
On 2012/04/23 15:23:43, alexeif wrote:
> On 2012/04/23 05:36:18, Yury Semikhatsky wrote:
> > Is it possible to merge such objects into the global one (in the snapshot)
to
> > avoid user confusion?
> Could you please elaborate?

I meant that it may be hard to explain to the user what things like
global_receiver on the global object are. I understand that it is accurate
representation of what's going on under the hood but since we are trying to
filter out some internal objects that would make sense to fix things like this
as well.