Issue 10166001: Duplicated typedef declaration of DeviceMap

Issue 10166001: Duplicated typedef declaration of DeviceMap (Closed)

Created:
8 years, 8 months ago by Jeremy Mao

Modified:
8 years, 8 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Duplicated typedef declaration of DeviceMap Created by yujie.mao@intel.com BUG=NONE TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133465

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	content/browser/renderer_host/media/media_stream_device_settings.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jeremy Mao

Find this issue when going through media related code. Hi wjia, Could please take a ...

8 years, 8 months ago (2012-04-20 08:28:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yujie.mao@intel.com/10166001/1

8 years, 8 months ago (2012-04-21 02:14:44 UTC) #3

commit-bot: I haz the power

Try job failure for 10166001-1 (retry) on win_rel for step "browser_tests". It's a second try, ...

8 years, 8 months ago (2012-04-21 04:48:13 UTC) #4

Jeremy Mao

On 2012/04/20 17:58:17, wjia wrote: > LGTM. Thanks for fixing this! Hi wjia, I have ...

8 years, 8 months ago (2012-04-23 01:47:33 UTC) #5

wjia(left Chromium)

8 years, 8 months ago (2012-04-23 17:11:47 UTC) #6

On 2012/04/23 01:47:33, Jeremy Mao wrote:
> On 2012/04/20 17:58:17, wjia wrote:
> > LGTM. Thanks for fixing this!
> 
> Hi wjia,
> 
> I have checked the failed test case, but it seems the failed test has no
> relationship with this code check-in.
> 
> Can you help me submit this commit directly? 

Done.

> 
> Thanks & Best regards
> Jeremy

Expand Messages | Collapse Messages