Issue 10164026: Reimplement RequestHiddenWifiNetworkProperties and RequestVirtualNetworkProperties without Libcros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10164026: Reimplement RequestHiddenWifiNetworkProperties and RequestVirtualNetworkProperties without Libcros (Closed)

Created:
8 years, 8 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reimplement RequestHiddenWifiNetworkProperties and RequestVirtualNetworkProperties without Libcros BUG=chromium-os:16557 TEST=unit_tests --gtest_filter="CrosNetworkFunctions*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133629

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and review fix #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -13 lines)			Patch
	M	chrome/browser/chromeos/cros/cros_network_functions.cc	View	1	3 chunks	+74 lines, -13 lines	0 comments	Download
	M	chrome/browser/chromeos/cros/cros_network_functions_unittest.cc	View		1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

lgtm with one change http://codereview.chromium.org/10164026/diff/1/chrome/browser/chromeos/cros/cros_network_functions.cc File chrome/browser/chromeos/cros/cros_network_functions.cc (right): http://codereview.chromium.org/10164026/diff/1/chrome/browser/chromeos/cros/cros_network_functions.cc#newcode527 chrome/browser/chromeos/cros/cros_network_functions.cc:527: flimflam::kTypeProperty, base::Value::CreateStringValue("vpn")); Use kTypeVPN

8 years, 8 months ago (2012-04-23 21:37:26 UTC) #2

hashimoto

8 years, 8 months ago (2012-04-24 03:53:11 UTC) #3

http://codereview.chromium.org/10164026/diff/1/chrome/browser/chromeos/cros/c...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/10164026/diff/1/chrome/browser/chromeos/cros/c...
chrome/browser/chromeos/cros/cros_network_functions.cc:527:
flimflam::kTypeProperty, base::Value::CreateStringValue("vpn"));
On 2012/04/23 21:37:26, stevenjb (chromium) wrote:
> Use kTypeVPN

Done.

Expand Messages | Collapse Messages