Issue 10164025: Add UMA stats for ObfuscatedFileUtil::GetDirectoryForOriginAndTypes().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10164025: Add UMA stats for ObfuscatedFileUtil::GetDirectoryForOriginAndTypes(). (Closed)

Created:
8 years, 8 months ago by tzik

Modified:
8 years, 7 months ago

Reviewers:
kinuko

CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add UMA stats for ObfuscatedFileUtil::GetDirectoryForOriginAndTypes(). BUG=103018 TEST='existing tests' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135802

Patch Set 5 : fix thread failure #

Patch Set 6 : s/REPORT_CASE/REPORT/g #

Total comments: 2

Patch Set 7 : label rename #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -30 lines)			Patch
M	webkit/fileapi/obfuscated_file_util.h	View	1 2	3 chunks	+17 lines, -5 lines	0 comments	Download
M	webkit/fileapi/obfuscated_file_util.cc	View	1 2	4 chunks	+50 lines, -10 lines	0 comments	Download
M	webkit/fileapi/sandbox_mount_point_provider.h	View	1 2 3 4	3 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/fileapi/sandbox_mount_point_provider.cc	View	1 2 3 4 5 6	6 chunks	+70 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinuko

lgtm http://codereview.chromium.org/10164025/diff/8006/webkit/fileapi/sandbox_mount_point_provider.cc File webkit/fileapi/sandbox_mount_point_provider.cc (right): http://codereview.chromium.org/10164025/diff/8006/webkit/fileapi/sandbox_mount_point_provider.cc#newcode46 webkit/fileapi/sandbox_mount_point_provider.cc:46: const char kOpenFileSystemBreakLabel[] = "FileSystem.OpenFileSystemBreak"; Break -> Detail? ...

8 years, 7 months ago (2012-05-08 06:29:17 UTC) #3

tzik

8 years, 7 months ago (2012-05-08 06:39:24 UTC) #4

Thanks!

http://codereview.chromium.org/10164025/diff/8006/webkit/fileapi/sandbox_moun...
File webkit/fileapi/sandbox_mount_point_provider.cc (right):

http://codereview.chromium.org/10164025/diff/8006/webkit/fileapi/sandbox_moun...
webkit/fileapi/sandbox_mount_point_provider.cc:46: const char
kOpenFileSystemBreakLabel[] = "FileSystem.OpenFileSystemBreak";
On 2012/05/08 06:29:17, kinuko wrote:
> Break -> Detail?
> Unique -> NonThrottled?

Done.

Expand Messages | Collapse Messages

Issue 10164025: Add UMA stats for ObfuscatedFileUtil::GetDirectoryForOriginAndTypes(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : fix thread failure #

Patch Set 6 : s/REPORT_CASE/REPORT/g #

Patch Set 7 : label rename #

Messages