History: Fix JavaScript style issues so presubmit checks pass.

History: Fix JavaScript style issues so presubmit checks pass.

BUG=122015
TEST=This CL is self-verifying. If it passes presubmit checks, then
history.js has no more presubmit errors.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133875

[Patrick Dubroy, 2012-04-20 13:25:14]

Hey Tyler, can you please review?

[Tyler Breisacher (Chromium), 2012-04-20 17:07:59]

lgtm with a couple nits.

If there are no other style issues in this directory, please add it to the list,
either in this CL or in a separate one:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/resources/w...

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
File chrome/browser/resources/history/history.js (right):

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.js:49: var Menu = cr.ui.Menu;
You can mark these /** @const */ if you want, but it's not critical.

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.js:521: * @param {number} depth How
many days back to do the search.
It looks like this is an optional parameter, so we can mark the type as
{number=}.
(http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...)

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.js:527: if (this.searchText_ == '') {
Not something we should fix in this CL, but it might be better to just write "if
(this.searchText_)" since '' is a falsy value.

[Patrick Dubroy, 2012-04-23 16:35:06]

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
File chrome/browser/resources/history/history.js (right):

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.js:49: var Menu = cr.ui.Menu;
On 2012/04/20 17:07:59, Tyler Breisacher wrote:
> You can mark these /** @const */ if you want, but it's not critical.

Done.

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.js:521: * @param {number} depth How
many days back to do the search.
On 2012/04/20 17:07:59, Tyler Breisacher wrote:
> It looks like this is an optional parameter, so we can mark the type as
> {number=}.
>
(http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...)

Done.

http://codereview.chromium.org/10164005/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.js:527: if (this.searchText_ == '') {
On 2012/04/20 17:07:59, Tyler Breisacher wrote:
> Not something we should fix in this CL, but it might be better to just write
"if
> (this.searchText_)" since '' is a falsy value.

You mean "if (!this.searchText_)" :-)

I'll fix in another CL.

[Tyler Breisacher (Chromium), 2012-04-24 21:00:17]

On 2012/04/23 16:35:06, dubroy wrote:
> You mean "if (!this.searchText_)" :-)

Yes, thank you. slgtm