Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/extensions/extension_processes_apitest.cc

Issue 10163019: Re-enabling browser_tests:ExtensionApiTest.ProcessesVsTaskManager. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/browser/extensions/extension_apitest.h" 6 #include "chrome/browser/extensions/extension_apitest.h"
7 #include "chrome/browser/extensions/extension_test_message_listener.h" 7 #include "chrome/browser/extensions/extension_test_message_listener.h"
8 #include "chrome/browser/task_manager/task_manager.h" 8 #include "chrome/browser/task_manager/task_manager.h"
9 #include "chrome/browser/task_manager/task_manager_browsertest_util.h" 9 #include "chrome/browser/task_manager/task_manager_browsertest_util.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
12 #include "chrome/common/chrome_switches.h" 12 #include "chrome/common/chrome_switches.h"
13 13
14 // Sometimes times out on Mac OS 14 // Sometimes times out on Mac OS
15 // crbug.com/ 15 // crbug.com/
16 #ifdef OS_MACOSX 16 #ifdef OS_MACOSX
17 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_Processes) { 17 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_Processes) {
18 #else 18 #else
19 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Processes) { 19 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Processes) {
20 #endif 20 #endif
21 CommandLine::ForCurrentProcess()->AppendSwitch( 21 CommandLine::ForCurrentProcess()->AppendSwitch(
22 switches::kEnableExperimentalExtensionApis); 22 switches::kEnableExperimentalExtensionApis);
23 23
24 ASSERT_TRUE(RunExtensionTest("processes/api")) << message_; 24 ASSERT_TRUE(RunExtensionTest("processes/api")) << message_;
25 } 25 }
26 26
27 // http://crbug.com/111787 27 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ProcessesVsTaskManager) {
28 #ifdef OS_WIN
29 #define MAYBE_ProcessesVsTaskManager DISABLED_ProcessesVsTaskManager
30 #else
31 #define MAYBE_ProcessesVsTaskManager ProcessesVsTaskManager
32 #endif
33 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_ProcessesVsTaskManager) {
34 CommandLine::ForCurrentProcess()->AppendSwitch( 28 CommandLine::ForCurrentProcess()->AppendSwitch(
35 switches::kEnableExperimentalExtensionApis); 29 switches::kEnableExperimentalExtensionApis);
36 30
37 // Ensure task manager is not yet updating 31 // Ensure task manager is not yet updating
38 TaskManagerModel* model = TaskManager::GetInstance()->model(); 32 TaskManagerModel* model = TaskManager::GetInstance()->model();
39 EXPECT_EQ(0, model->update_requests_); 33 EXPECT_EQ(0, model->update_requests_);
40 EXPECT_EQ(TaskManagerModel::IDLE, model->update_state_); 34 EXPECT_EQ(TaskManagerModel::IDLE, model->update_state_);
41 35
42 // Load extension that adds listener in background page 36 // Load extension that adds listener in background page
43 ExtensionTestMessageListener listener("ready", false); 37 ExtensionTestMessageListener listener("ready", false);
44 ASSERT_TRUE(LoadExtension( 38 ASSERT_TRUE(LoadExtension(
45 test_data_dir_.AppendASCII("processes").AppendASCII("onupdated"))); 39 test_data_dir_.AppendASCII("processes").AppendASCII("onupdated")));
46 ASSERT_TRUE(listener.WaitUntilSatisfied()); 40 ASSERT_TRUE(listener.WaitUntilSatisfied());
47 41
48 // Ensure the task manager has started updating 42 // Ensure the task manager has started updating
49 EXPECT_EQ(1, model->update_requests_); 43 EXPECT_EQ(1, model->update_requests_);
50 EXPECT_EQ(TaskManagerModel::TASK_PENDING, model->update_state_); 44 EXPECT_EQ(TaskManagerModel::TASK_PENDING, model->update_state_);
51 45
52 // Now show the task manager and wait for it to be ready 46 // Now show the task manager and wait for it to be ready
53 TaskManagerBrowserTestUtil::ShowTaskManagerAndWaitForReady(browser()); 47 TaskManagerBrowserTestUtil::ShowTaskManagerAndWaitForReady(browser());
54 48
55 EXPECT_EQ(2, model->update_requests_); 49 EXPECT_EQ(2, model->update_requests_);
56 EXPECT_EQ(TaskManagerModel::TASK_PENDING, model->update_state_); 50 EXPECT_EQ(TaskManagerModel::TASK_PENDING, model->update_state_);
57 51
58 // Unload the extension and check that listener count decreases 52 // Unload the extension and check that listener count decreases
59 UnloadExtension(last_loaded_extension_id_); 53 UnloadExtension(last_loaded_extension_id_);
60 EXPECT_EQ(1, model->update_requests_); 54 EXPECT_EQ(1, model->update_requests_);
61 } 55 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698