editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java - Issue 10162026: Report warnings and non-fatal errors for shadowing declaration and usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java

Issue 10162026: Report warnings and non-fatal errors for shadowing declaration and usage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweaks for review comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameTypeMemberProcessor.java ('k') | editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameAnalyzeUtilTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java b/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java

index 461f64f34766cbb276cb0e24b6b43c96724a83f0..0a7678721247cfea1a4fd3bf599d721c24d63df0 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java

@@ -16,8 +16,8 @@ package com.google.dart.tools.ui.refactoring;

import com.google.common.collect.Lists;

import com.google.dart.tools.ui.internal.refactoring.UserInteractions;

-import org.eclipse.core.runtime.IStatus;

import org.eclipse.ltk.core.refactoring.RefactoringStatus;

+import org.eclipse.ltk.core.refactoring.RefactoringStatusEntry;

import org.eclipse.swt.widgets.Shell;

import java.util.List;

@@ -29,6 +29,7 @@ public abstract class RefactoringTest extends AbstractDartTest {

protected final List<String> openInformationMessages = Lists.newArrayList();

+ protected final List<Integer> showStatusSeverities = Lists.newArrayList();

protected final List<String> showStatusMessages = Lists.newArrayList();

protected boolean showStatusCancel;

@@ -45,7 +46,12 @@ public abstract class RefactoringTest extends AbstractDartTest {

UserInteractions.showStatusDialog = new UserInteractions.ShowStatusDialog() {

@Override

public boolean open(RefactoringStatus status, Shell parent, String windowTitle) {

- showStatusMessages.add(status.getMessageMatchingSeverity(IStatus.INFO));

+ RefactoringStatusEntry[] entries = status.getEntries();

+ for (RefactoringStatusEntry entry : entries) {

+ int severity = entry.getSeverity();

+ showStatusSeverities.add(severity);

+ showStatusMessages.add(entry.getMessage());

+ }

return showStatusCancel;

}

};