Issue 10162021: Let Windows SendInput() calculate the VK for USB events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10162021: Let Windows SendInput() calculate the VK for USB events. (Closed)

Created:
8 years, 8 months ago by Wez

Modified:
8 years, 8 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Let Windows SendInput() calculate the VK for USB events. Windows SendInput() API provides a flag callers can use to have the API do the conversion, which is more reliable than doing it manually with MapVirtualKeyEx(). BUG=124499 TEST=Manual. Verify that NumLock behaves as expected when connecting between two Windows hosts using Chromoting. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133784

Patch Set 1 #

Patch Set 2 : Fix typo. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -24 lines)			Patch
	M	remoting/host/event_executor_win.cc	View	1	2 chunks	+19 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10162021/2001

8 years, 8 months ago (2012-04-24 19:48:27 UTC) #5

commit-bot: I haz the power

8 years, 8 months ago (2012-04-24 20:55:12 UTC) #6

Try job failure for 10162021-2001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages