Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 10162005: Eliminate internal and hidden links to oddballs and other non-essential objects in heap snapshot. (Closed)

Created:
8 years, 8 months ago by alexeif
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Eliminate internal and hidden links to oddballs and other non-essential objects in heap snapshot. Committed: https://code.google.com/p/v8/source/detail?r=11404

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M src/profile-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/profile-generator.cc View 1 5 chunks +18 lines, -12 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeif
It eliminates half of the links on gmail.com, so I'm expecting up to 2x performance ...
8 years, 8 months ago (2012-04-20 13:05:58 UTC) #1
yurys
Can you add a test for this? https://chromiumcodereview.appspot.com/10162005/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10162005/diff/1/src/profile-generator.cc#newcode2466 src/profile-generator.cc:2466: // empty_*_array ...
8 years, 8 months ago (2012-04-20 13:08:40 UTC) #2
mnaganov (inactive)
Yes, test please.
8 years, 8 months ago (2012-04-20 13:14:57 UTC) #3
alexeif
https://chromiumcodereview.appspot.com/10162005/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10162005/diff/1/src/profile-generator.cc#newcode2466 src/profile-generator.cc:2466: // empty_*_array object itself is being processed all its ...
8 years, 8 months ago (2012-04-20 13:33:50 UTC) #4
yurys
8 years, 8 months ago (2012-04-20 13:48:36 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698