Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 10162001: Replaced the --limit-inling flag by three separate flags and bumped hard limits. (Closed)

Created:
8 years, 8 months ago by Sven Panne
Modified:
8 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Replaced the --limit-inling flag by three separate flags and bumped hard limits. This change makes experiments with inlining limits much easier. Note that the default values for the limits keep their old values for now. Renamed things a bit for more consistency. Committed: https://code.google.com/p/v8/source/detail?r=11397

Patch Set 1 #

Patch Set 2 : Removed previous uses of --nolimit-inlining. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M src/api.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M test/mjsunit/compiler/alloc-object-huge.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
8 years, 8 months ago (2012-04-20 07:17:21 UTC) #1
Jakob Kummerow
LGTM
8 years, 8 months ago (2012-04-20 07:21:59 UTC) #2
Sven Panne
I've missed 2 uses of --nolimit-inlining in our sources, new patch set uploaded...
8 years, 8 months ago (2012-04-20 10:33:10 UTC) #3
Jakob Kummerow
8 years, 8 months ago (2012-04-20 10:34:43 UTC) #4
still LGTM.

Powered by Google App Engine
This is Rietveld 408576698