Adding UsbService and UsbDevice constructs.

chrome/browser/profiles/profile.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class gathers state related to a single user profile.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_H_
 #pragma once
 
@@ skipping 18 matching lines @@
 class ExtensionSpecialStoragePolicy;
 class FaviconService;
 class GAIAInfoUpdateService;
 class HistoryService;
 class HostContentSettingsMap;
 class PasswordStore;
 class PrefService;
 class PromoCounter;
 class ProtocolHandlerRegistry;
 class TestingProfile;
+class UsbService;
 class UserScriptMaster;
 class VisitedLinkMaster;
 class WebDataService;
 
 namespace base {
 class Time;
 }
 
 namespace chromeos {
 class LibCrosServiceLibraryImpl;
@@ skipping 339 matching lines @@
   // method returns data is not guaranteed to be deleted.
   virtual void ClearNetworkingHistorySince(base::Time time) = 0;
 
   // Returns the home page for this profile.
   virtual GURL GetHomePage() = 0;
 
   // Returns whether or not the profile was created by a version of Chrome
   // more recent (or equal to) the one specified.
   virtual bool WasCreatedByVersionOrLater(const std::string& version) = 0;
 
+#if !defined(OS_ANDROID)

[sail, 2012/04/25 21:06:36]

it's a bad idea to have #ifdefs in code. The general approach is to define this
on all platform and implement a stub for android.

If this is not practical then another approach would be to move this ifdef to
only the profile_impl.cc file. This ways callers can do something like this:
  service = profile()->GetUsbService();
  // Service may not exists on some platforms.
  if (!service)
    return;

+  // Returns or creates and returns an instance of the UsbService.

[miket_OOO, 2012/04/25 21:24:36]

This is a minor point, but the "or creates and returns" feels like an
implementation detail that the caller shouldn't care about. Isn't "Returns..."
enough?

+  virtual UsbService* GetUsbService() = 0;
+#endif  // !defined(OS_ANDROID)
+
   std::string GetDebugName();
 
   // Returns whether it is a guest session.
   static bool IsGuestSession();
 
 #ifdef UNIT_TEST
   // Use with caution.  GetDefaultRequestContext may be called on any thread!
   static void set_default_request_context(net::URLRequestContextGetter* c) {
     default_request_context_ = c;
   }
@@ skipping 71 matching lines @@
 struct hash<Profile*> {
   std::size_t operator()(Profile* const& p) const {
     return reinterpret_cast<std::size_t>(p);
   }
 };
 
 }  // namespace BASE_HASH_NAMESPACE
 #endif
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_H_