Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 10161025: Allow about:tracing Counters to be selected (Closed)

Created:
8 years, 8 months ago by nduca
Modified:
8 years, 8 months ago
Reviewers:
jbates
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Allow about:tracing Counters to be selected, with supporting refactorings. The selection infrastructure in about:tracing was grown organically and in a hurry. This refactors the organic selection logic around the concept of a TimelineSelection, which represents an array of TimelineSelectionHit objects. A selection hit is created by a track and contains enough information to uniquely identify the selection both in the track and in the overall TimelineModel. Counter tracks are then updated to support this new picking infrastructure, generating TimelineSelectionHits. Whereas TimelineSelectionSliceHit stores its selected state inside the timeline model, TimelineSelectionCounterHit stores its selected state inside the track. The counter hits follow the new intended model; a followon refactoring will be needed to clean up the TimelineSlice selection state. As part of this refactoring, the analysis code for traces is pulled from the timeline view into a standalone analysis class. This allows cleanup and unit testing of that once-monolithic system. In doing this, the help dialog is moved up to a custom button in the UI instead of being shown in the analysis area as was done previously. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133535

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1031 lines, -407 lines) Patch
M chrome/browser/resources/tracing.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/tracing.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/tracing/interactive_tests.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/tracing/profiling_view_test.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/tracing/test_utils.js View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/resources/tracing/tests.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/tracing/timeline.js View 9 chunks +195 lines, -106 lines 0 comments Download
A chrome/browser/resources/tracing/timeline_analysis.css View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/resources/tracing/timeline_analysis.js View 1 chunk +160 lines, -0 lines 0 comments Download
A chrome/browser/resources/tracing/timeline_analysis_test.html View 1 chunk +114 lines, -0 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_test.html View 2 chunks +48 lines, -3 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_track.js View 1 15 chunks +190 lines, -84 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_track_test.html View 1 13 chunks +176 lines, -46 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_view.css View 4 chunks +29 lines, -10 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_view.js View 10 chunks +63 lines, -133 lines 0 comments Download
M chrome/browser/resources/tracing/timeline_view_test.html View 1 9 chunks +31 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nduca
WIP, but ready for coarse review
8 years, 8 months ago (2012-04-23 11:33:25 UTC) #1
jbates
8 years, 8 months ago (2012-04-23 20:44:23 UTC) #2
coarse lgtm

http://codereview.chromium.org/10161025/diff/1/chrome/browser/resources/traci...
File chrome/browser/resources/tracing/timeline_view_test.html (right):

http://codereview.chromium.org/10161025/diff/1/chrome/browser/resources/traci...
chrome/browser/resources/tracing/timeline_view_test.html:93:
selection.push_(this.addAllObjectsMatchingFilterToSelectionReturnValue[i]);
nit: 80 chars

Powered by Google App Engine
This is Rietveld 408576698