Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10161022: Fix performance regression on some benchmarks: add an extendable array type where push and pop can … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart (revision 6831)
+++ lib/compiler/implementation/ssa/builder.dart (working copy)
@@ -2164,9 +2164,9 @@
if (originalElement.isGenerativeConstructor()
&& originalElement.enclosingElement === compiler.listClass) {
if (node.arguments.isEmpty()) {
+ type = HType.EXTENDABLE_ARRAY;
+ } else {
type = HType.MUTABLE_ARRAY;
- } else {
- type = HType.READABLE_ARRAY;
}
} else if (element.isGenerativeConstructor()) {
ClassElement cls = element.enclosingElement;
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698