chrome/installer/setup/install.h - Issue 10160011: Create VisualElementsManifest.xml from template -- install VisualElements in the version directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.h

Issue 10160011: Create VisualElementsManifest.xml from template -- install VisualElements in the version directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add comment Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install.h

diff --git a/chrome/installer/setup/install.h b/chrome/installer/setup/install.h

index 370c51e46053630e40da6a52718d530d760139e7..b3a931383223bdd31c119bc2451bcecdcfc09a7d 100644

--- a/chrome/installer/setup/install.h

+++ b/chrome/installer/setup/install.h

@@ -23,6 +23,17 @@ class InstallationState;

class InstallerState;

class MasterPreferences;

+// Escape the display name as per the XML AttValue production

+// (http://www.w3.org/TR/2008/REC-xml-20081126/#NT-AttValue) for a value in

+// single quotes.

+void EscapeXmlAttributeValueInSingleQuotes(string16& att_value);

grt (UTC plus 2) 2012/05/04 21:22:42 pass by pointer since att_value is modified.

gab 2012/05/04 23:02:09 Done.

+// Creates VisualElementsManifest.xml beside chrome.exe in |src_path| if

+// |src_path|\VisualElements exists.

+// Returns true unless the manifest is supposed to be created, but fails to be.

+bool CreateVisualElementsManifest(const FilePath& src_path,

+ const Version& version);

// This function installs or updates a new version of Chrome. It returns

// install status (failed, new_install, updated etc).

« no previous file with comments | « chrome/installer/mini_installer/chrome.release ('k') | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install_unittest.cc » ('J')