Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1537)

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 101573003: Add the navigation redirect-chain to Sync sessions proto for offline analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from creis on patch set 43. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/proto_value_conversions.cc
diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc
index 135842005e8c77dff240d7a3e8f83061c13c040b..bce114e5c0b073f9ee4ae9020098b8c531d28e27 100644
--- a/sync/protocol/proto_value_conversions.cc
+++ b/sync/protocol/proto_value_conversions.cc
@@ -205,6 +205,15 @@ base::DictionaryValue* TabNavigationToValue(
SET_INT32(http_status_code);
SET_INT32(referrer_policy);
SET_BOOL(is_restored);
+ SET_REP(navigation_redirect, NavigationRedirectToValue);
+ SET_STR(last_navigation_redirect_url);
+ return value;
+}
+
+base::DictionaryValue* NavigationRedirectToValue(
+ const sync_pb::NavigationRedirect& proto) {
+ base::DictionaryValue* value = new base::DictionaryValue();
+ SET_STR(url);
return value;
}

Powered by Google App Engine
This is Rietveld 408576698