status_icons: Fold RemoveAllIcons() into StatusTray dtor.

status_icons: Fold RemoveAllIcons() into StatusTray dtor.

This function is called only once and thus we can get rid of it now.

R=atwilson@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133357

[Andrew T Wilson (Slow), 2012-04-20 19:13:09]

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
File chrome/browser/status_icons/status_tray.cc (right):

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
chrome/browser/status_icons/status_tray.cc:29: DCHECK(i != status_icons_.end());
I think I'd prefer this to read:
if (i == status_icons_.end()) {
  NOTREACHED();
  return;
}

That way we error out in debug versions, but in release versions we don't trash
memory. What do you think?

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
File chrome/browser/status_icons/status_tray.h (right):

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
chrome/browser/status_icons/status_tray.h:31: // Removes the current status icon
associated with this identifier, if any.
Since we're changing RemoveStatusIcon(), we should update the documentation.
This documentation is old anyway since we no longer refer to icons via their
identifiers.

[tfarina, 2012-04-20 19:24:13]

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
File chrome/browser/status_icons/status_tray.cc (right):

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
chrome/browser/status_icons/status_tray.cc:29: DCHECK(i != status_icons_.end());
On 2012/04/20 19:13:09, Andrew T Wilson wrote:
> I think I'd prefer this to read:
> if (i == status_icons_.end()) {
>   NOTREACHED();
>   return;
> }
> 
> That way we error out in debug versions, but in release versions we don't
trash
> memory. What do you think?

Done.

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
File chrome/browser/status_icons/status_tray.h (right):

http://codereview.chromium.org/10156004/diff/6001/chrome/browser/status_icons...
chrome/browser/status_icons/status_tray.h:31: // Removes the current status icon
associated with this identifier, if any.
On 2012/04/20 19:13:09, Andrew T Wilson wrote:
> Since we're changing RemoveStatusIcon(), we should update the documentation.
> This documentation is old anyway since we no longer refer to icons via their
> identifiers.

Done.

[Andrew T Wilson (Slow), 2012-04-20 20:55:47]

LGTM