[NaCl SDK] Build naclmono packages based on the sdk manifest.

Build naclmono packages based on the sdk manifest.

Re-purpose linux-sdk-mono64 bot to build these release packages, since
all the continuous building is happening on linux-sdk-mono32, this one is free.

BUG=115363
TEST=bots,manual

Note: This CL only affects the Native Client SDK
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133731

[elijahtaylor1, 2012-04-20 00:40:48]

We can talk about this CL tomorrow, but wanted to give you a chance to look at
it early if you wanted.

This is the other half of https://chromiumcodereview.appspot.com/9693053/ ,
which I need to re-roll in another CL since it's so old now.

This is the generator of my own manifest files which would be treated as add-ons
to the sdk.

[binji, 2012-04-20 17:55:17]

few questions, but otherwise lgtm

http://codereview.chromium.org/10156003/diff/1001/native_client_sdk/src/build...
File native_client_sdk/src/build_tools/nacl-mono-buildbot.py (right):

http://codereview.chromium.org/10156003/diff/1001/native_client_sdk/src/build...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:63:
'gs://nativeclient-mirror/nacl/nacl_sdk/naclmono_manifest.json', '.'])
could you make globals for these paths, I didn't realize they were different at
first.

BTW, I was going to look at this file, but it doesn't seem to allow public
access?

http://codereview.chromium.org/10156003/diff/1001/native_client_sdk/src/build...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:79: info['naclmono_rev']
= str(bundle[0]['revision']+1)
why +1?

http://codereview.chromium.org/10156003/diff/1001/native_client_sdk/src/build...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:109: archive['url'] =
('https://commondatastorage.googleapis.com/'
I don't think this is the right path.
This will be:
  https://.../nacl/naclsdk/naclmono_20/<revision>/naclmono_20.bz2

But the archiver still puts it in:
  https://.../nacl/naclsdk/<revision>/naclmono_20.bz2

right?

http://codereview.chromium.org/10156003/diff/1001/native_client_sdk/src/build...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:146:
build_and_upload_mono(sdk_revision, pepper_revision, None, sdk_revision)
There is a discrepancy here:
the mono tarballs are uploaded to
  gs://nativeclient-mirror/nacl/nacl_sdk/<revision>

but the sdk tarballs are uploaded to
  gs://nativeclient-mirror/nacl/nacl_sdk/<pepper version>
or
  gs://nativeclient-mirror/nacl/nacl_sdk/trunk.<revision>

using build_utils.ChromeVersion()

Might be nice to be consistent here if we can.

[elijahtaylor1, 2012-04-20 18:52:50]

Thanks for the review, great feedback.  I'm glad someone else is double-checking
my paths.

I've added comments or fixes to address your feedback so far.   I've also added
one extra bit of logic to deal with sdk bundles that go from dev to beta, etc.
but don't change their revision.  Please forgive minor code duplication, it
didn't seem worth it to factor it out at this point.

PTAL

https://chromiumcodereview.appspot.com/10156003/diff/1001/native_client_sdk/s...
File native_client_sdk/src/build_tools/nacl-mono-buildbot.py (right):

https://chromiumcodereview.appspot.com/10156003/diff/1001/native_client_sdk/s...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:63:
'gs://nativeclient-mirror/nacl/nacl_sdk/naclmono_manifest.json', '.'])
On 2012/04/20 17:55:17, binji wrote:
> could you make globals for these paths, I didn't realize they were different
at
> first.
> 
> BTW, I was going to look at this file, but it doesn't seem to allow public
> access?

Done.

https://chromiumcodereview.appspot.com/10156003/diff/1001/native_client_sdk/s...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:79: info['naclmono_rev']
= str(bundle[0]['revision']+1)
On 2012/04/20 17:55:17, binji wrote:
> why +1?

Added a comment

https://chromiumcodereview.appspot.com/10156003/diff/1001/native_client_sdk/s...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:109: archive['url'] =
('https://commondatastorage.googleapis.com/'
On 2012/04/20 17:55:17, binji wrote:
> I don't think this is the right path.
> This will be:
>   https://.../nacl/naclsdk/naclmono_20/%3Crevision%3E/naclmono_20.bz2
> 
> But the archiver still puts it in:
>   https://.../nacl/naclsdk/%3Crevision%3E/naclmono_20.bz2
> 
> right?

Added a comment below to show where this naclmono_20/<revision>/naclmono_20.bz2
construction comes from

https://chromiumcodereview.appspot.com/10156003/diff/1001/native_client_sdk/s...
native_client_sdk/src/build_tools/nacl-mono-buildbot.py:146:
build_and_upload_mono(sdk_revision, pepper_revision, None, sdk_revision)
On 2012/04/20 17:55:17, binji wrote:
> There is a discrepancy here:
> the mono tarballs are uploaded to
>   gs://nativeclient-mirror/nacl/nacl_sdk/<revision>
> 
> but the sdk tarballs are uploaded to
>   gs://nativeclient-mirror/nacl/nacl_sdk/<pepper version>
> or
>   gs://nativeclient-mirror/nacl/nacl_sdk/trunk.<revision>
> 
> using build_utils.ChromeVersion()
> 
> Might be nice to be consistent here if we can.

I could be wrong, but I think maybe trunk.<rev> is a newer construction than
these scripts which might explain why these are different.  Fixed to be
consistent with trunk.<rev> for the continuous builds

[binji, 2012-04-20 20:10:51]

slgtm

[noelallen1, 2012-04-21 19:13:21]

LGTM for owners