Issue 10155029: win: Fix a small language violation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10155029: win: Fix a small language violation. (Closed)

Created:
8 years, 8 months ago by Nico

Modified:
8 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, Alexei Svitkine (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

win: Fix a small language violation. No functionality change. Found by clang. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133703

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	base/win/registry.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10155029/2001

8 years, 8 months ago (2012-04-24 16:25:21 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-24 16:25:24 UTC) #4

Presubmit check for 10155029-2001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    base/win/registry.h:87

Expand Messages | Collapse Messages