Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10155028: Fix error in test.dart where a process will be closed twice. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 1eeb00e8268906b3b80c9393f8934e3f6068534e..5a48c0d1eac2f89214ecb83a57020d4eeffbaa40 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -551,7 +551,11 @@ class RunningProcess {
* the actual test and its output is analyzed in [testComplete].
*/
void stepExitHandler(int exitCode) {
- process.close();
+ try {
+ process.close();
+ } catch (ProcessException e) {
+ // If the process is already closed, continue.
+ }
int totalSteps = testCase.commands.length;
String suffix =' (step $currentStep of $totalSteps)';
if (currentStep == totalSteps) { // done with test command
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698