ash/accelerators/accelerator_filter.cc - Issue 10155015: Process all global shortcuts for Ash after InputMethodEventFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/accelerator_filter.cc

Issue 10155015: Process all global shortcuts for Ash after InputMethodEventFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, address comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/accelerators/accelerator_filter.cc

diff --git a/ash/accelerators/accelerator_filter.cc b/ash/accelerators/accelerator_filter.cc

index 049f94cd4089d8a48c306b8a1e6d53ebe7fffb31..dcc95ba9bd9c037f56383601b29a4ffb724b0278 100644

--- a/ash/accelerators/accelerator_filter.cc

+++ b/ash/accelerators/accelerator_filter.cc

@@ -35,10 +35,8 @@ AcceleratorFilter::~AcceleratorFilter() {

bool AcceleratorFilter::PreHandleKeyEvent(aura::Window* target,

aura::KeyEvent* event) {

const ui::EventType type = event->type();

- if (type != ui::ET_KEY_PRESSED && type != ui::ET_TRANSLATED_KEY_PRESS &&

- type != ui::ET_KEY_RELEASED && type != ui::ET_TRANSLATED_KEY_RELEASE) {

+ if (type != ui::ET_KEY_PRESSED && type != ui::ET_KEY_RELEASED)

return false;

- }

if (event->is_char())

return false;

« no previous file with comments | « ash/accelerators/accelerator_dispatcher.cc ('k') | ash/accelerators/accelerator_table.h » ('j') | no next file with comments »