Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10155013: We must also check if the first input of a phi is unknown. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/src/TypePropagationInForUpdateTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart (revision 6826)
+++ lib/compiler/implementation/ssa/nodes.dart (working copy)
@@ -1842,8 +1842,8 @@
// different known types, we'll return a conflict -- otherwise we'll
// simply return an unknown type.
HType computeInputsType(bool unknownWins) {
- bool seenUnknown = false;
HType candidateType = inputs[0].propagatedType;
+ bool seenUnknown = candidateType.isUnknown();
for (int i = 1, length = inputs.length; i < length; i++) {
HType inputType = inputs[i].propagatedType;
if (inputType.isUnknown()) {
« no previous file with comments | « no previous file | tests/language/src/TypePropagationInForUpdateTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698