Issue 10155006: Cancel unnecessary spellcheck requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10155006: Cancel unnecessary spellcheck requests. (Closed)

Created:
8 years, 8 months ago by Hironori Bono

Modified:
8 years, 8 months ago

Reviewers:
Hajime Morrita

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cancel unnecessary spellcheck requests. This change calls WebTextCheckingCompletion::didCancelCheckingText when Chrome does not spellcheck text sent from WebKit to prevent WebKit from removing markers. (This is a Chrome-side change for <http://trac.webkit.org/changeset/114605>.) Also, this change fills suggestions when using hunspell for asynchronous spellchecking. BUG=107371 TEST=SpellCheckProviderTest.CancelUnnecessaryRequests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133401

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -16 lines)			Patch
M	chrome/renderer/spellchecker/spellcheck.cc	View	4 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc	View	3 chunks	+36 lines, -1 line	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_unittest.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm.

Expand Messages | Collapse Messages