ui/views/widget/widget.h - Issue 10154013: Fixes crash in closing menus. There are two issues here:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget.h

Issue 10154013: Fixes crash in closing menus. There are two issues here: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixor Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/widget.h

diff --git a/ui/views/widget/widget.h b/ui/views/widget/widget.h

index c2f4eb44699d06cb9e6cc293b6ee1098092f45ac..955a72edc2b0e0f1deb5af7fe9fca9157fb416bb 100644

--- a/ui/views/widget/widget.h

+++ b/ui/views/widget/widget.h

@@ -606,6 +606,9 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,

// Returns the bounds of work area in the screen that Widget belongs to.

gfx::Rect GetWorkAreaBoundsInScreen() const;

+ // Notification that our owned parent is closing.

+ virtual void OnOwnedParentClosing();

Ben Goodger (Google) 2012/04/26 02:34:54 owning parent? or how about OnOwnerClosing()?

// Overridden from NativeWidgetDelegate:

virtual bool IsModal() const OVERRIDE;

virtual bool IsDialogBox() const OVERRIDE;