chrome/test/base/view_event_test_base.cc - Issue 10154013: Fixes crash in closing menus. There are two issues here:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/view_event_test_base.cc

Issue 10154013: Fixes crash in closing menus. There are two issues here: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: OnOwnerClosing and more comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/view_event_test_base.cc

diff --git a/chrome/test/base/view_event_test_base.cc b/chrome/test/base/view_event_test_base.cc

index a98b80ef3d96e5e80e599f71f6666bfd7e980fce..91be23d506802ec6594773321abc14c179d7b8e6 100644

--- a/chrome/test/base/view_event_test_base.cc

+++ b/chrome/test/base/view_event_test_base.cc

@@ -68,7 +68,8 @@ void ViewEventTestBase::Done() {

#if defined(OS_WIN) && !defined(USE_AURA)

// We need to post a message to tickle the Dispatcher getting called and

// exiting out of the nested loop. Without this the quit never runs.

- PostMessage(window_->GetNativeWindow(), WM_USER, 0, 0);

+ if (window_)

+ PostMessage(window_->GetNativeWindow(), WM_USER, 0, 0);

#endif

// If we're in a nested message loop, as is the case with menus, we